add a healthy dose of locks to generic functions #17250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1888,12 +1890,14 @@ static void jl_add_linfo_root(jl_lambda_info_t *li, jl_value_t *val) | |||
| size_t rlen = jl_array_dim0(m->roots); | |||
| for(size_t i=0; i < rlen; i++) { | |||
| if (jl_array_ptr_ref(m->roots,i) == val) { | |||
| jl_mutex_unlock(&li->def->writelock); | |||
| @@ -1878,6 +1879,7 @@ static void jl_add_linfo_root(jl_lambda_info_t *li, jl_value_t *val) | |||
| if (jl_is_leaf_type(val) || jl_is_bool(val) || jl_is_symbol(val)) | |||
| return; | |||
| JL_GC_PUSH1(&val); | |||
| JL_LOCK(&li->def->writelock); | |||
|
Nice!! #16524 probably needs a few more atomic operations to make sure the write is visibly in a consistent state for the reader but this should be good enough for now. |
|
I rebased this to resolve the conflict with #17116 (also resolved #17250 (comment)) There seems to be many other issues according to the CI though... |
| @@ -1176,13 +1180,16 @@ void *jl_get_llvmf(jl_tupletype_t *tt, bool getwrapper, bool getdeclarations) | |||
| } | |||
| if (linfo->jlcall_api == 2) { | |||
| // normally we don't generate native code for these functions, so need an exception here | |||
| if (linfo->functionObjectsDecls.functionObject == NULL) | |||
| to_function(linfo); | |||
| // Yes, this leaks lots of memory. No, I don't care. | |||
There was a problem hiding this comment.
Uh, why not? This isn't the kind of comment we want to have sitting around in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix a couple of recently-introduced data-flow ordering bugs in typeinf
fix #17059
fix #16524