Move Combinatorics migrations to deprecated.jl #16175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes they are permanent deprecations and they do belong in |
|
permanent would mean they should be left in place indefinitely, putting them in deprecated.jl means they'll be removed after another release or two. |
|
I thought you meant permanent as simply "permanently removed from Base", which was why I was confused. I presume it's ok to have them go through the usual deprecation cycle, but maybe emitting the error is useful for fixing up legacy code? I don't really have a strong opinion either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jiahao and ref #13897, any reason this wasn't put in
deprecated.jl? Seems like if it stays where it currently is then it'd be easy to forget about it. Were these intended to be permanent deprecations?