Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-15074: Added OS info about building from source in README #15210

Closed
wants to merge 0 commits into from

Conversation

goelakash
Copy link
Contributor

#15074 It was mentioned that building via make is not a universal solution. I have added a small change to notify user about which OS' this works with. Should I also add a line wrt to Windows as -

"To build on Windows, see instructions on how to compile from source using Visual Studio or install Cygwin"?
I am not sure whats the correct recommendation, or Julia community's policies about these are.
Please review.

@tkelman
Copy link
Contributor

tkelman commented Feb 24, 2016

There's a separate readme with full instructions for building on windows, we have a link to it at https://github.com/JuliaLang/julia#windows but it's a ways down the page. Building with Visual Studio is highly experimental and not something we can officially support right now (see #12056).

@goelakash
Copy link
Contributor Author

@tkelman How about I add "For details see #link" in there?

@tkelman
Copy link
Contributor

tkelman commented Feb 25, 2016

Dunno, there are a lot of build dependencies besides just make. We could say See [Platform-Specific Build Notes](#Platform-Specific-Notes) for more details. or something like that.

@goelakash
Copy link
Contributor Author

I did add that. Seems ok now.

@tkelman
Copy link
Contributor

tkelman commented Feb 25, 2016

The part you added To build on Linux, OSX(with **make** utility installed) or other *nix systems, is a bit overly verbose and strangely formatted. We build on Windows using make as well. I'd say add the short link right after the short sentence the way it was.

@goelakash goelakash closed this Feb 25, 2016
@goelakash goelakash deleted the issue-15074 branch February 25, 2016 07:39
@goelakash goelakash restored the issue-15074 branch February 25, 2016 07:39
@goelakash goelakash deleted the issue-15074 branch February 25, 2016 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants