sign(::Complex): make sign of complex zero respect signs of parts #14806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not realize that we defined signum for complex numbers. This doesn't seem right to me (#10000 ?): julia> sign(-0.0im) #+0.0-0.0im?
-0.0 - 0.0im
julia> sign(-0.0-0.0im)
-0.0 - 0.0im
julia> sign(0.0-0.0im)
0.0 - 0.0imApparently, there are multiple extensions to complex numbers and we should document which one we implement ( |
|
Since |
|
Oh, talk about subtle. |
|
My issue is orthogonal to this PR. Otherwise lgtm |
StefanKarpinski
added a commit
that referenced
this pull request
Feb 17, 2016
sign(::Complex): make sign of complex zero respect signs of parts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #14621.