A couple of Makefile tweaks #14103
Merged
A couple of Makefile tweaks #14103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does it matter which c++ std library patchelf gets built against? |
|
If you're building everything with sanitizer it'll fail otherwise. Of course, the alternative solution is to change to build rules to prevent patchelf from being built with sanitizers, but that seemed like an annoying special case. |
|
Huh. Picky, but whatever. It's also used on arpack, I suspect you'll need to change |
- If we're building the world with a custom C++ library, make sure PATCHELF picks up the correct flags both at build time and when we use it. - Fix base/version_git.sh to also work when using O= out of tree builds (important for Compat, etc.)
Keno
force-pushed
the
kf/makefiletweaks
branch
from
702d227 to
5fd2095
Compare
|
Thanks, not sure why I missed that one. |
It's the prerequisite for this rule, so touching it will invalidate the libuv for all other trees.
|
This also seems to fix the infinite loop in |
|
whoops, sorry about that, we can revert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATCHELF picks up the correct flags both at build time and when
we use it.
builds (important for Compat, etc.)