cache dependency mtimes and check equality, not mtime(dep) <= mtime(cache) #12559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #12458, it is a good idea to store the timestamp of the dependency files in the
.ji
file, so that we can check staleness by comparing that the dependency timestamp is equal to the cached value, not just that the dependency is older than the cachefile (alamake
). This has two advantages:Of course, we may still want to use a hash or checksum at some point, but this is a free-of-cost thing that we can do now.