Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object_id with padding #12442

Merged
merged 1 commit into from
Aug 4, 2015
Merged

Fix object_id with padding #12442

merged 1 commit into from
Aug 4, 2015

Conversation

carnaval
Copy link
Contributor

@carnaval carnaval commented Aug 3, 2015

Forgotten in the padding fix : immutables with haspadding fields.

julia> immutable K; x::Bool; y::Int; end
julia> immutable K3; x::K; end
julia> object_id(K3(K(false,1)))
0x2816178d071f22f3
julia> object_id(K3(K(false,1)))
0x7eaed272352f26d8

turns out Dict don't like that.

@tkelman
Copy link
Contributor

tkelman commented Aug 3, 2015

can you add a test?

@carnaval
Copy link
Contributor Author

carnaval commented Aug 3, 2015

done

@JeffBezanson
Copy link
Member

Thank you!

The test can be made more reliable using the method of the test for #11813.

@carnaval carnaval force-pushed the ob/fixoid branch 2 times, most recently from b721a4f to 8c536c5 Compare August 3, 2015 20:57
Forgotten in the padding fix : immutables with haspadding fields.
carnaval added a commit that referenced this pull request Aug 4, 2015
@carnaval carnaval merged commit e66175b into master Aug 4, 2015
@carnaval carnaval deleted the ob/fixoid branch August 4, 2015 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants