-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add faster replace
#12224
Re-add faster replace
#12224
Conversation
cc @tkelman I'd just commit this but for the AV failure, let's make sure it's nothing serious first. |
here's the appveyor error, for reference
|
Wow, they have a new interface! The error message is due to #12144 (comment) and the hang is the usual one.... |
Restarted AppVeyor. Original failure here |
AppVeyor still looks the same to me, are you referring to the tweaked PR status indicator here on github? |
Yes |
This is the part of #11898 that was inadvertently clobbered by the string refactoring.