Disable test for ReadOnlyMemoryError for now #11704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some corruption on 32bit linux #11691
|
The tests pass Compare to ~13 failures with the test, this should at least proof that the failure is indeed caused by the mmap test. |
|
We should look into why the test is failing, but I don't see any reason to leave master and a bunch of PR's failing. |
JeffBezanson
added a commit
that referenced
this pull request
Jun 14, 2015
Disable test for ReadOnlyMemoryError for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11691
From the build just now (which I have restarted to double check), disabling this test seems to make the segfault disappear.
I think this is an issue that should be properly fixed. We could probably keep #11691 open (maybe change the title) to track the issue but in the mean time, there's probably not much point of keeping a known failure in the test.