Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh add HorizontalRule to markdown #10483

Merged
merged 1 commit into from
Mar 14, 2015
Merged

enh add HorizontalRule to markdown #10483

merged 1 commit into from
Mar 14, 2015

Conversation

hayd
Copy link
Member

@hayd hayd commented Mar 12, 2015

Adds horizontal rule, <hr />, like this one:


cc @one-more-minute (Note: this precedence required for this appears to be before paragraph.)

@hayd
Copy link
Member Author

hayd commented Mar 12, 2015

Hmmm, weird/suprising behaviour of the @md_str macro is the reason for the failing test:

julia> md"Hello\n\n---\nWorld"
  Hello\n\n–-\nWorld

julia> md"""Hello

       ---

       World"""
  Hello

  ---------------------------------------------------------------------------------------------------------------------------

  World

julia> Markdown.parse("Hello\n\n---\nWorld")
  Hello

  ---------------------------------------------------------------------------------------------------------------------------

  World

Pushed a fix.

fix used multiple lines in md_str
@MikeInnes
Copy link
Member

Seems like the build failure is just a timeout, I think that can be ignored.

Is the md"" behaviour that surprising? I don't think \n style escaping is part of CommonMark – to me it would be more surprising if typing paths and such entered random newlines.

MikeInnes added a commit that referenced this pull request Mar 14, 2015
enh add HorizontalRule to markdown
@MikeInnes MikeInnes merged commit 6856f9d into JuliaLang:master Mar 14, 2015
@hayd hayd deleted the hr branch March 14, 2015 17:19
@hayd
Copy link
Member Author

hayd commented Mar 14, 2015

Fair enough, that that makes sense. I expected "a\nb" to always behave the same as an actual new line (as it does in julia), I do still think it is a little surprising that it doesn't...

Thanks for looking/merging all these!

@MikeInnes
Copy link
Member

Thank you for the contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants