fix a bug in code that restores the prompt on ^C #10416
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing #10405 I noticed a bug in the mechanism that gives control back to the REPL on ^C:
and the REPL is dead and never comes back. The problem is that when task S dies (as expected), it sees the REPL is "waiting" and so throws the error to it. But the REPL is actually waiting for the backend channel (I think) and not for something that should be interrupted.
My fix is to only throw the error to the REPL if the REPL is in the middle of evaluating something. This patch works but is clearly pretty hacky. Would like to figure out the right way to do this. cc @Keno