Add getindex(::Pair) + tests for Pairs #10152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uncontroversial? I thought I'd sweeten the deal by adding tests :). More controversial was the idea to do getindex(p::Pair, x::Bool) = ifelse(x,p.first,p.second)which would allow an alternative ternary syntax like y = (1=>2)[x in set]but that might be too confusing..... |
|
Yeah I find that pretty obfuscated. |
|
Yeah, I think it was cool realizing we could do something like that, but then realizing it's probably not very nice generally. |
|
I'm pretty sure the OSX failure is unrelated (timeout while running some package tests?). These passed for me locally on OSX. |
|
Looks like the appveyor failure is #10045. |
quinnj
added a commit
that referenced
this pull request
Feb 11, 2015
Add getindex(::Pair) + tests for Pairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.