-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rethrow()
-> throw()
#43669
Comments
Hi, I am new to open source and I want to fix this essue can you give me some suggestions on how to start. |
@pcm135 Best to wait on some more opinions for this one. This is not a bug but a feature request. |
This is a reasonable idea, but I think there is a further distinction between |
Fair enough. Maybe its a docs issue, probably |
It seems reasonable to have the docstring for |
Check PR, rethrow already mentions throw so I haven't added it again. |
Unless I'm missing something, there is no use of the zero-argument
throw()
at the moment. Also,?rethrow
discourages usingrethrow(e)
in favour ofthrow(e)
. This is a suggestion to delete/deprecaterethrow
and use a zero-argument form ofthrow()
for rethrowing the current error. The motivation is simplification, and to avoid immediately presenting new Julians with caveats (?rethrow
). Personally I seem to forget about rethrow every time I return to Julia, because I'm thinking in terms of multiple dispatch andthrow()
seems more natural. Python's raise also behaves in a similar way: https://docs.python.org/3/reference/simple_stmts.html#index-27The text was updated successfully, but these errors were encountered: