Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking relpath change on Windows with Julia 1.6 #40237

Closed
rofinn opened this issue Mar 27, 2021 · 1 comment · Fixed by #40323
Closed

Breaking relpath change on Windows with Julia 1.6 #40237

rofinn opened this issue Mar 27, 2021 · 1 comment · Fixed by #40323
Labels
system:windows Affects only Windows

Comments

@rofinn
Copy link
Contributor

rofinn commented Mar 27, 2021

I realize I should have been testing on nightly to catch things like this earlier, but it looks like a breaking relpath change was introduced in Julia 1.6 for Windows. The following test now fails:

rel_str = joinpath("..", "src", "FilePathsBase.jl")
rel_fp = Path(rel_str)
@test relpath(abspath(rel_str)) == rel_str
@test string(relpath(absolute(rel_fp))) == rel_str

with

relpath: Test Failed at D:\a\FilePathsBase.jl\FilePathsBase.jl\test\system.jl:224
  Expression: relpath(abspath(rel_str)) == rel_str
   Evaluated: "D:\\a\\FilePathsBase.jl\\FilePathsBase.jl\\src\\FilePathsBase.jl" == "..\\src\\FilePathsBase.jl"

I'm guessing this was introduced by #38259 because the default startpath of . doesn't have a drive letter? I'm guessing we probably want to special case relative path arguments? I can make a PR, but I just wanted to confirm that we want to maintain the old behaviour first.

https://github.com/rofinn/FilePathsBase.jl/runs/2206524503?check_suite_focus=true#step:7:86

rofinn added a commit to rofinn/FilePathsBase.jl that referenced this issue Mar 27, 2021
@musm musm added the system:windows Affects only Windows label Apr 2, 2021
@musm
Copy link
Contributor

musm commented Apr 2, 2021

#40323 should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:windows Affects only Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants