RFC: Some degree trigonometric functions, sind, cosd, tand, asind , acosd, asecd, acsd, acotd, atand accept a square matrix.
#39758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `acosd`, `asecd`, `acsd`, `acotd` accept an square matrix.
AtsushiSakai
changed the title
sind, cosd, tand, asind , acosd, asecd, acsd, acotd accept an square matrix.sind, cosd, tand, asind , acosd, asecd, acsd, acotd accept a square matrix.
|
I close/reopen to rerun CI. |
|
I think the CI error is not related this PR. |
|
@StefanKarpinski @simonbyrne Could one of you (or someone else) take a look? |
|
I fixed a conflict of News.md. PTAL. |
|
I do want another set of eyes on this. Trying @dkarrasch @StefanKarpinski @simonbyrne. |
|
Why do we not do this for all the trig functions? For example - |
AtsushiSakai
changed the title
sind, cosd, tand, asind , acosd, asecd, acsd, acotd accept a square matrix.sind, cosd, tand, asind , acosd, asecd, acsd, acotd, atand accept a square matrix.
AtsushiSakai
commented
May 15, 2021
| @@ -1294,5 +1302,5 @@ end | |||
|
|
|||
| Compute the inverse tangent of `y` or `y/x`, respectively, where the output is in degrees. | |||
| """ | |||
| atand(y) = rad2deg(atan(y)) | |||
| atand(y, x) = rad2deg(atan(y,x)) | |||
| atand(y) = rad2deg.(atan(y)) | |||
There was a problem hiding this comment.
@ViralBShah Thank you for your comment. The PR title and news.md was missing atand, but it supports a square matrix by this change.
AtsushiSakai
commented
May 15, 2021
| @test tand(TAA) == tan(deg2rad.(TAA)) | ||
| @test asind(TAA) == rad2deg.(asin(TAA)) | ||
| @test acosd(TAA) == rad2deg.(acos(TAA)) | ||
| @test atand(TAA) == rad2deg.(atan(TAA)) |
There was a problem hiding this comment.
@ViralBShah atand is tested here.
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
…ind` , `acosd`, `asecd`, `acsd`, `acotd`, `atand` accept a square matrix. (JuliaLang#39758) * Some degree trigonometric functions, `sind`, `cosd`, `tand`, `asind`, `acosd`, `asecd`, `acsd`, `acotd` accept an square matrix. * add PR number and change argument name to be the same as in the document. * Update NEWS.md * add `atand` for News.md. Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…ind` , `acosd`, `asecd`, `acsd`, `acotd`, `atand` accept a square matrix. (JuliaLang#39758) * Some degree trigonometric functions, `sind`, `cosd`, `tand`, `asind`, `acosd`, `asecd`, `acsd`, `acotd` accept an square matrix. * add PR number and change argument name to be the same as in the document. * Update NEWS.md * add `atand` for News.md. Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved some degree trigonometric functions,
sind,cosd,tand,asind,acosd,asecd,acscd,acotdto accept an square matrix to fix JuliaLang/LinearAlgebra.jl#651.Also, I added some tests, updated docs of these functions, updated NEWS.md, and generalized a unit convert function as a for loop element which is proposed in #27254 (comment).