Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF docs deployment broken #33968

Closed
cdluminate opened this issue Nov 28, 2019 · 13 comments · Fixed by #35227
Closed

PDF docs deployment broken #33968

cdluminate opened this issue Nov 28, 2019 · 13 comments · Fixed by #35227
Assignees
Labels
docsystem The documentation building system upstream The issue is with an upstream dependency, e.g. LLVM

Comments

@cdluminate
Copy link
Contributor

The PDF document is invalid:

https://raw.githubusercontent.com/JuliaLang/docs.julialang.org/assets/julia-1.3.0.pdf

and the link is found here:

https://docs.julialang.org/en/v1.3/

@fredrikekre fredrikekre self-assigned this Nov 28, 2019
@fredrikekre fredrikekre added the docsystem The documentation building system label Nov 28, 2019
@aerdely
Copy link

aerdely commented Dec 17, 2019

Still broken as of today 😕

@ViralBShah
Copy link
Member

Would be nice to fix this. I am happy to do it, if there's instructions I can follow somewhere.

@xerz-one
Copy link

The build script should be the one at julialang/docs.julialang.org. To run it (you might have to install dependencies like PDFLaTeX or Docker, I haven't figured that out), you have to do something like:

git clone https://github.com/JuliaLang/docs.julialang.org
git clone https://github.com/JuliaLang/julia
cd docs.julialang.org/pdf
JULIA_SOURCE=../../julia julia make.jl releases

I decided to modify the make.jl script with my own small patches, to save myself some time and effort, adding a #!/usr/bin/env julia header and rewriting the following function:

function collect_versions()
    versions = VersionNumber[]
    push!(versions, v"1.3.0")
    return versions
end

...and I got this error

┌ Error: LaTeXWriter: failed to compile tex with docker. Logs and partial output can be found in /tmp/jl_yokbBF.
│   exception =
│    failed process: Process(`docker exec -u zeptodoctor latex-container bash -c 'mkdir /home/zeptodoctor/build
│    cd /home/zeptodoctor/build
│    cp -r /mnt/. .
│    latexmk -f -interaction=nonstopmode -view=none -lualatex -shell-escape TheJuliaLanguage.tex
│    '`, ProcessExited(12)) [12]
│    
└ @ Documenter.Writers.LaTeXWriter ~/Projects/julia/doc/deps/packages/Documenter/cMNJA/src/Writers/LaTeXWriter.jl:173

@xerz-one
Copy link

(keep in mind: I keep my Julia repo at ~/Projects/julia, and I couldn't find that /tmp/jl_yokbBF anywhere)

@fredrikekre
Copy link
Member

This is the real issue: JuliaDocs/Documenter.jl#1200

@StefanKarpinski StefanKarpinski added the upstream The issue is with an upstream dependency, e.g. LLVM label Dec 18, 2019
@aerdely
Copy link

aerdely commented Dec 19, 2019

The problem has been fixed!

@StefanKarpinski
Copy link
Member

It was fixed manually, we should still track the upstream issue to make sure the PDF is automatically generated in the future.

@ViralBShah
Copy link
Member

Inside the pdf, it says the manual is for 1.3.0-alpha. Not sure if it is the right manual with an incorrect version, or if it is an older manual.

@ViralBShah ViralBShah changed the title [v1.3.0] invalid PDF documentation [v1.3.0] PDF documentation says it is for 1.3-alpha Dec 28, 2019
@fredrikekre
Copy link
Member

It's an older manual.

@fredrikekre fredrikekre changed the title [v1.3.0] PDF documentation says it is for 1.3-alpha PDF deployment broken Jan 10, 2020
@fredrikekre fredrikekre changed the title PDF deployment broken PDF docs deployment broken Jan 10, 2020
@ViralBShah
Copy link
Member

Should we remove the pdf link from the manual until this gets fixed?

ViralBShah added a commit that referenced this issue Mar 22, 2020
While #33968 is yet to be fixed upstream, we should avoid showing the pdf link in the manual
@knuesel
Copy link
Member

knuesel commented Apr 14, 2020

The link on https://docs.julialang.org/en/v1/ is still broken.

@fredrikekre
Copy link
Member

No, it just broke due to 1.4.1. PDFs are generated once a day so it will be up tomorrow.

@ViralBShah
Copy link
Member

I had no idea the pdf docs were so popular!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docsystem The documentation building system upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants