Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float16(1f5) is NaN16 instead of Inf16 #33076

Closed
rfourquet opened this issue Aug 26, 2019 · 0 comments · Fixed by #33084
Closed

Float16(1f5) is NaN16 instead of Inf16 #33076

rfourquet opened this issue Aug 26, 2019 · 0 comments · Fixed by #33084
Labels
bug Indicates an unexpected problem or unintended behavior maths Mathematical functions regression Regression in behavior compared to a previous version

Comments

@rfourquet
Copy link
Member

This changed some time in the last three months or so, before we had Float16(1f5) == Inf16.
Similarly, we had and still have Float32(1e39) == Inf32.
This broke a test in BitIntegers.jl.
cc @Keno as #32444 seems to be the last to touch this method.
@rfourquet rfourquet added bug Indicates an unexpected problem or unintended behavior maths Mathematical functions labels Aug 26, 2019
@rfourquet rfourquet changed the title isnan(Float16(1f5)) Float16(1f5) is NaN16 instead of Inf16 Aug 26, 2019
Keno added a commit that referenced this issue Aug 26, 2019
@Keno
Fix Float16 conversion from large Float32s
2fc362e 
Fixes #33076
@Keno Keno mentioned this issue Aug 26, 2019
Merged
@JeffBezanson JeffBezanson added the regression Regression in behavior compared to a previous version label Aug 26, 2019
Keno added a commit that referenced this issue Aug 29, 2019
@Keno
Fix Float16 conversion from large Float32s (#33084)
7bc7904 
Fixes #33076
JeffBezanson pushed a commit that referenced this issue Aug 30, 2019
@Keno @JeffBezanson
Fix Float16 conversion from large Float32s (#33084)
8e092f7 
Fixes #33076
(cherry picked from commit 7bc7904)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior maths Mathematical functions regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Float16 conversion from large Float32s JuliaLang/julia
2 participants
@JeffBezanson @rfourquet