Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate read(io, type, dims) #21450

Closed
JeffBezanson opened this issue Apr 20, 2017 · 0 comments · Fixed by #22456
Closed

deprecate read(io, type, dims) #21450

JeffBezanson opened this issue Apr 20, 2017 · 0 comments · Fixed by #22456
Labels
domain:io Involving the I/O subsystem: libuv, read, write, etc. kind:deprecation This change introduces or involves a deprecation
Milestone
0.7

Comments

@JeffBezanson
Copy link
Sponsor Member

Just noticed this. We have read{T}(s::IO, ::Type{T}, dims::Dims) that's defined to call read!(s, Array{T}(dims)). It would be better just to deprecate it to that.
@JeffBezanson JeffBezanson added kind:deprecation This change introduces or involves a deprecation domain:io Involving the I/O subsystem: libuv, read, write, etc. labels Apr 20, 2017
@JeffBezanson JeffBezanson added this to the 1.0 milestone Apr 20, 2017
JeffBezanson added a commit that referenced this issue Jun 21, 2017
@JeffBezanson
change read(::IO, ::Ref) to read!`, fix fix #21592
598a018 
deprecate `read(io, type, dims)`, fix #21450
@JeffBezanson JeffBezanson mentioned this issue Jun 21, 2017
Merged
JeffBezanson added a commit that referenced this issue Jun 21, 2017
@JeffBezanson
change read(::IO, ::Ref) to read!`, fix fix #21592
e3891d2 
deprecate `read(io, type, dims)`, fix #21450
JeffBezanson added a commit that referenced this issue Jun 21, 2017
@JeffBezanson
change read(::IO, ::Ref) to read!`, fix fix #21592
eb83294 
deprecate `read(io, type, dims)`, fix #21450
JeffBezanson added a commit that referenced this issue Jun 30, 2017
@JeffBezanson
change read(::IO, ::Ref) to read!`, fix fix #21592
5e80d9c 
deprecate `read(io, type, dims)`, fix #21450
JeffBezanson added a commit that referenced this issue Jul 7, 2017
@JeffBezanson
change read(::IO, ::Ref) to read!`, fix fix #21592
b94e242 
deprecate `read(io, type, dims)`, fix #21450
JeffBezanson added a commit that referenced this issue Jul 9, 2017
@JeffBezanson
change read(::IO, ::Ref) to read!`, fix fix #21592
d61d5ac 
deprecate `read(io, type, dims)`, fix #21450
jeffwong pushed a commit to jeffwong/julia that referenced this issue Jul 24, 2017
@JeffBezanson @jeffwong
change read(::IO, ::Ref) to read!`, fix fix JuliaLang#21592
cbb4f4e 
deprecate `read(io, type, dims)`, fix JuliaLang#21450
traktofon added a commit to traktofon/julia that referenced this issue Feb 4, 2018
@traktofon
Correct replacement for read(io, type dims)
e0b0f09 
It says

> read(io, type, dims) is deprecated to read!(io, Array{type}(dims)) (JuliaLang#21450).

but in turn `Array{type}(dims)` is deprecated to `Array{type}(uninitialized, dims)`. Fix to inform users about the correct replacement.
JeffBezanson pushed a commit that referenced this issue Feb 4, 2018
@traktofon @JeffBezanson
Correct replacement for read(io, type dims) (#25878)
a1bec2a 
It says

> read(io, type, dims) is deprecated to read!(io, Array{type}(dims)) (#21450).

but in turn `Array{type}(dims)` is deprecated to `Array{type}(uninitialized, dims)`. Fix to inform users about the correct replacement.
@cormullion cormullion mentioned this issue Mar 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:io Involving the I/O subsystem: libuv, read, write, etc. kind:deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

some I/O deprecations JuliaLang/julia
1 participant
@JeffBezanson