Fix log message id from at-deprecate to be a Symbol.

JuliaLang · May 13, 2021 · fa26381 · fa26381
1 parent a0241b9
commit fa26381
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/base/deprecated.jl b/base/deprecated.jl
@@ -93,8 +93,8 @@ function depwarn(msg, funcsym; force::Bool=false)
         end,
         _file=String(caller.file),
         _line=caller.line,
-        _id=(frame,funcsym),
         _group=:depwarn,
+        frame=frame,
         caller=caller,
         maxlog=funcsym === nothing ? nothing : 1
     )

diff --git a/test/corelogging.jl b/test/corelogging.jl
@@ -437,6 +437,14 @@ end
     @test record.group == :corelogging  # name of this file
 end
 
+@testset "id from @deprecate should be ::Symbol" begin
+    f() = Base.depwarn("msg", :f; force=true)
+    logs, _ = Test.collect_test_logs() do
+        f()
+    end
+    @test logs[1].id isa Symbol
+end
+
 @testset "complicated kwargs logging macro" begin
     @test_logs (:warn, "foo")  @warn "foo" argvals=:((DoNotCare{$(Expr(:escape, :Any))}(),))
 end