always send log messages to stderr by default (#41653)

JuliaLang · Jul 20, 2021 · e196b85 · e196b85
1 parent d26dc9e
commit e196b85
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 17 deletions.
diff --git a/base/logging.jl b/base/logging.jl
@@ -670,7 +670,7 @@ function handle_message(logger::SimpleLogger, level::LogLevel, message, _module,
     buf = IOBuffer()
     stream = logger.stream
     if !isopen(stream)
-        stream = level < Warn ? stdout : stderr
+        stream = stderr
     end
     iob = IOContext(buf, stream)
     levelstr = level == Warn ? "Warning" : string(level)

diff --git a/stdlib/Logging/src/ConsoleLogger.jl b/stdlib/Logging/src/ConsoleLogger.jl
@@ -119,7 +119,7 @@ function handle_message(logger::ConsoleLogger, level::LogLevel, message, _module
     msglines = [(indent=0, msg=l) for l in split(chomp(string(message)::String), '\n')]
     stream = logger.stream
     if !isopen(stream)
-        stream = level < Warn ? stdout : stderr
+        stream = stderr
     end
     dsize = displaysize(stream)::Tuple{Int,Int}
     nkwargs = length(kwargs)::Int

diff --git a/test/corelogging.jl b/test/corelogging.jl
@@ -341,20 +341,6 @@ end
         String(take!(io))
     end
 
-    function genmsg_out(level, message, _module, filepath, line; kws...)
-        fname = tempname()
-        f = open(fname, "w")
-        logger = SimpleLogger()
-        redirect_stdout(f) do
-            handle_message(logger, level, message, _module, :group, :id,
-                           filepath, line; kws...)
-        end
-        close(f)
-        buf = read(fname)
-        rm(fname)
-        String(buf)
-    end
-
     function genmsg_err(level, message, _module, filepath, line; kws...)
         fname = tempname()
         f = open(fname, "w")
@@ -370,7 +356,7 @@ end
     end
 
     # Simple
-    @test genmsg_out(Info, "msg", Main, "some/path.jl", 101) ==
+    @test genmsg_err(Info, "msg", Main, "some/path.jl", 101) ==
     """
     ┌ Info: msg
     └ @ Main some/path.jl:101