Deprecate flipud() and fliplr() in favor of flipdim()

We do not provide other convenience functions for any other operation, like size(), and these names are obscure for non-MATLAB users.
JuliaLang · Mar 9, 2015 · bb7dec9 · bb7dec9
1 parent b80f7db
commit bb7dec9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 12 deletions.
diff --git a/base/abstractarray.jl b/base/abstractarray.jl
@@ -518,9 +518,6 @@ function flipdim(A::AbstractArray, d::Integer)
     return B
 end
 
-flipud(A::AbstractArray) = flipdim(A, 1)
-fliplr(A::AbstractArray) = flipdim(A, 2)
-
 circshift(a::AbstractArray, shiftamt::Real) = circshift(a, [integer(shiftamt)])
 function circshift{T,N}(a::AbstractArray{T,N}, shiftamts)
     I = ()

diff --git a/base/deprecated.jl b/base/deprecated.jl
@@ -294,6 +294,9 @@ const base64 = base64encode
 # 10314
 @deprecate filter!(r::Regex, d::Dict) filter!((k,v)->ismatch(r,k), d)
 
+@deprecate flipud(A::AbstractArray) flipdim(A, 1)
+@deprecate fliplr(A::AbstractArray) flipdim(A, 2)
+
 # 0.4 discontinued functions
 
 @noinline function subtypetree(x::DataType, level=-1)

diff --git a/base/dsp.jl b/base/dsp.jl
@@ -163,7 +163,7 @@ function xcorr(u, v)
     elseif sv < su
         v = [v;zeros(eltype(v),su-sv)]
     end
-    flipud(conv(flipud(u), v))
+    flipdim(conv(flipdim(u, 1), v), 1)
 end
 
 fftshift(x) = circshift(x, div([size(x)...],2))

diff --git a/doc/stdlib/arrays.rst b/doc/stdlib/arrays.rst
@@ -267,14 +267,6 @@ Indexing, Assignment, and Concatenation
 
    Reverse ``A`` in dimension ``d``.
 
-.. function:: flipud(A)
-
-   Equivalent to ``flipdim(A,1)``.
-
-.. function:: fliplr(A)
-
-   Equivalent to ``flipdim(A,2)``.
-
 .. function:: circshift(A,shifts)
 
    Circularly shift the data in an array. The second argument is a vector giving the amount to shift in each dimension.