Skip to content

Commit

Permalink
escape space-after-colon so yaml parser stops complaining
Browse files Browse the repository at this point in the history
  • Loading branch information
@tkelman
tkelman committed Nov 7, 2014
1 parent 04e4c05 commit ab0d6ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ before_install:
fi
script:
- if git --no-pager grep --color -n --full-name ' $' -- \*.jl \*.scm \*.c \*.cpp \*.h; then
echo "Error: trailing whitespace found in source file(s)";
echo "Error:\ trailing whitespace found in source file(s)";

This comment has been minimized.

Sign in to view

Copy link
@eschnett

eschnett Nov 7, 2014

Contributor

To escape the colon, shouldn't the backslash be in front of it?

This comment has been minimized.

Sign in to view

Copy link
@tkelman

tkelman Nov 7, 2014

Author Contributor

it's the colon followed by a space that makes the yaml parser mad. this backslash isn't actually escaping anything, I should probably just remove the colon or replace it with something yaml doesn't care about.

This comment has been minimized.

Sign in to view

Copy link
@eschnett

eschnett Nov 7, 2014

Contributor

Could you instead quote the whole line? If it was completely enclosed in single quotes, wouldn't yaml remove them?
exit 1;
fi
- make $BUILDOPTS prefix=/tmp/julia install
Expand Down

4 comments on commit ab0d6ca

@jakebolewski
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, thanks.

@tkelman
Copy link
Contributor Author

@tkelman tkelman commented on ab0d6ca Nov 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops that results in the backslash showing up in the message

@tkelman
Copy link
Contributor Author

@tkelman tkelman commented on ab0d6ca Nov 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about dash instead of colon? yaml doesnt seem to care about that

@jakebolewski
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't care, not broken is best :-)

Please sign in to comment.