Merge pull request #17660 from Sacha0/defullconcat

Remove `full` from `similar(full(X), T, dims)` calls in generic concatenation methods.
JuliaLang · Oct 8, 2016 · 89a2500 · 89a2500
2 parents a05852b + c9bd807
commit 89a2500
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/base/abstractarray.jl b/base/abstractarray.jl
@@ -1014,7 +1014,7 @@ function typed_vcat{T}(::Type{T}, V::AbstractVector...)
     for Vk in V
         n += length(Vk)
     end
-    a = similar(full(V[1]), T, n)
+    a = similar(V[1], T, n)
     pos = 1
     for k=1:length(V)
         Vk = V[k]
@@ -1042,7 +1042,7 @@ function typed_hcat{T}(::Type{T}, A::AbstractVecOrMat...)
         nd = ndims(Aj)
         ncols += (nd==2 ? size(Aj,2) : 1)
     end
-    B = similar(full(A[1]), T, nrows, ncols)
+    B = similar(A[1], T, nrows, ncols)
     pos = 1
     if dense
         for k=1:nargs
@@ -1074,7 +1074,7 @@ function typed_vcat{T}(::Type{T}, A::AbstractMatrix...)
             throw(ArgumentError("number of columns of each array must match (got $(map(x->size(x,2), A)))"))
         end
     end
-    B = similar(full(A[1]), T, nrows, ncols)
+    B = similar(A[1], T, nrows, ncols)
     pos = 1
     for k=1:nargs
         Ak = A[k]
@@ -1303,7 +1303,7 @@ function typed_hvcat{T}(::Type{T}, rows::Tuple{Vararg{Int}}, as::AbstractMatrix.
         a += rows[i]
     end
 
-    out = similar(full(as[1]), T, nr, nc)
+    out = similar(as[1], T, nr, nc)
 
     a = 1
     r = 1