Skip to content

Commit

Permalink
improve error message when artifact not found (#46264)
Browse files Browse the repository at this point in the history
`Pkg.instantiate()` does not fix the issue anymore if the artifact is
not part of a package, so this points users to
`Pkg.ensure_artifact_installed`.

Ref JuliaPackaging/ArtifactUtils.jl#13
  • Loading branch information
simeonschaub authored Aug 9, 2022
1 parent 4c41a07 commit 686afd3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion stdlib/Artifacts/src/Artifacts.jl
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,8 @@ function _artifact_str(__module__, artifacts_toml, name, path_tail, artifact_dic
suggestion_str = if query_override(hash) !== nothing
"Check that your `Overrides.toml` file is correct (https://pkgdocs.julialang.org/v1/artifacts/#Overriding-artifact-locations)."
else
"Try `using Pkg; Pkg.instantiate()` to re-install all missing resources."
"Try `using Pkg; Pkg.instantiate()` to re-install all missing resources if the artifact is part of a package \
or call `Pkg.ensure_artifact_installed` (https://pkgdocs.julialang.org/v1/api/#Pkg.Artifacts.ensure_artifact_installed) if not."
end

error("Artifact $(repr(name)) was not found by looking in the $(path_str)$suggestion_str")
Expand Down

6 comments on commit 686afd3

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@vtjnash
Copy link
Member

@vtjnash vtjnash commented on 686afd3 Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your job failed.

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/JuliaCI/NanosoldierReports/blob/master/benchmark/by_date/2022-08/09/report.md

seems some possible minor hiccups with that, across about 41 commits

@nanosoldier runbenchmarks("arithmetic" || "mix_scalar_tuple", vs="@e2a8a4e6b3bb333fdab5a5c9a023fe96e2f39c92")

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

Please sign in to comment.