Skip to content

Commit

Permalink
[BugReporting] pass ARGS through properly (#39839)
Browse files Browse the repository at this point in the history
When calling `make_interactive_report()`, we really need to pass in
`ARGS` as well, otherwise it always starts an interactive session.

This commit, in combination with `--` allows the user to run an `rr`
session while still passing arguments to the child `julia` process via:

```
julia --bug-report=rr -- --project test/runtests.jl
```
  • Loading branch information
staticfloat authored Mar 2, 2021
1 parent 3ff44ea commit 5e7aaa6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion stdlib/InteractiveUtils/src/InteractiveUtils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ function report_bug(kind)
else
BugReporting = Base.require(BugReportingId)
end
return Base.invokelatest(BugReporting.make_interactive_report, kind)
return Base.invokelatest(BugReporting.make_interactive_report, kind, ARGS)
end

end

2 comments on commit 5e7aaa6

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

Please sign in to comment.