Skip to content

Commit

Permalink
add warning if cycle detected in extensions
Browse files Browse the repository at this point in the history
  • Loading branch information
IanButterworth committed Jan 30, 2024
1 parent 3ed1ee7 commit 3d2e2bd
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions base/loading.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1392,6 +1392,10 @@ function run_extension_callbacks(pkgid::PkgId)
extids = pop!(EXT_DORMITORY, pkgid, nothing)
extids === nothing && return
for extid in extids
if in(extid.id.name, precompilation_stack) && !isprecompiled(extid.id)
@warn "Dependency cycle detected in extension precompilation: $(join(precompilation_stack, " > ")) > $(extid.id.name)"
continue
end
if extid.ntriggers > 0
# indicate pkgid is loaded
extid.ntriggers -= 1
Expand Down

0 comments on commit 3d2e2bd

Please sign in to comment.