Skip to content

Commit

Permalink
a couple of tidy ups on #47300 (#47320)
Browse files Browse the repository at this point in the history
Co-Authored-By: Jameson Nash <vtjnash+github@gmail.com>

Co-authored-by: Jameson Nash <vtjnash+github@gmail.com>
  • Loading branch information
IanButterworth and vtjnash authored Oct 25, 2022
1 parent 4a45e8b commit 35d1289
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion stdlib/Profile/src/Profile.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,7 @@ function take_heap_snapshot(filepath::String, all_one::Bool=false)
return filepath
end
function take_heap_snapshot(all_one::Bool=false)
f = joinpath(pwd(), "$(getpid())_$(time_ns()).heapsnapshot")
f = abspath("$(getpid())_$(time_ns()).heapsnapshot")
return take_heap_snapshot(f, all_one)
end

Expand Down
4 changes: 1 addition & 3 deletions stdlib/Profile/test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,7 @@ end
end

@testset "HeapSnapshot" begin
fname = strip(String(read(
`$(Base.julia_cmd()) --startup-file=no -E "using Profile; Profile.take_heap_snapshot()"`
)), ['\n', '\"'])
fname = read(`$(Base.julia_cmd()) --startup-file=no -e "using Profile; print(Profile.take_heap_snapshot())"`, String)

@test isfile(fname)

Expand Down

2 comments on commit 35d1289

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true, configuration=(rr=true,))

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

Please sign in to comment.