implement @StefanKarpinski's suggestion for #11618

closes #11618
JuliaLang · Aug 11, 2015 · 2fbf675 · 2fbf675
1 parent 66f336d
commit 2fbf675
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/base/reduce.jl b/base/reduce.jl
@@ -20,8 +20,8 @@ r_promote(op, x::WidenReduceResult) = widen(x)
 r_promote(op, x) = x
 r_promote(::AddFun, x::WidenReduceResult) = widen(x)
 r_promote(::MulFun, x::WidenReduceResult) = widen(x)
-r_promote(::AddFun, x::Number) = x + zero(x)
-r_promote(::MulFun, x::Number) = x * one(x)
+r_promote(::AddFun, x::Number) = oftype(x + zero(x), x)
+r_promote(::MulFun, x::Number) = oftype(x * one(x), x)
 r_promote(::AddFun, x) = x
 r_promote(::MulFun, x) = x
 r_promote(::MaxFun, x::WidenReduceResult) = x

diff --git a/test/reduce.jl b/test/reduce.jl
@@ -270,3 +270,8 @@ end
 
 @test sum(collect(map(UInt8,0:255))) == 32640
 @test sum(collect(map(UInt8,254:255))) == 509
+
+# issue #11618
+@test sum([-0.0]) === -0.0
+@test sum([-0.0, -0.0]) === -0.0
+@test prod([-0.0, -0.0]) === 0.0