Fix underlines in cmd printing

Fixes #25589
JuliaLang · Aug 6, 2018 · 224da24 · 224da24
1 parent e3bc48d
commit 224da24
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/base/process.jl b/base/process.jl
@@ -102,13 +102,13 @@ function show(io::IO, cmd::Cmd)
     print_dir = !isempty(cmd.dir)
     (print_env || print_dir) && print(io, "setenv(")
     print(io, '`')
-    print(io, join(map(cmd.exec) do arg
-        replace(sprint() do io
+    join(io, map(cmd.exec) do arg
+        replace(sprint(context=io) do io
             with_output_color(:underline, io) do io
                 print_shell_word(io, arg, shell_special)
             end
         end, '`' => "\\`")
-    end, ' '))
+    end, ' ')
     print(io, '`')
     print_env && (print(io, ","); show(io, cmd.env))
     print_dir && (print(io, "; dir="); show(io, cmd.dir))

diff --git a/test/show.jl b/test/show.jl
@@ -1401,3 +1401,8 @@ end
     @test replstr(Union{X28004,Vector}[X28004(Any[X28004(1)])]) ==
         "1-element Array{Union{X28004, Array{T,1} where T},1}:\n X(Any[X(1)])"
 end
+
+# Issue 25589 - Underlines in cmd printing
+replstrcolor(x) = sprint((io, x) -> show(IOContext(io, :limit => true, :color => true),
+                                         MIME("text/plain"), x), x)
+@test occursin("\e[", replstrcolor(`curl abc`))