fix #33675, unpredictable summarysize on isbitsunion arrays (#33713)

JuliaLang · Oct 29, 2019 · 1b6101a · 1b6101a
1 parent 97f142f
commit 1b6101a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/base/summarysize.jl b/base/summarysize.jl
@@ -125,7 +125,7 @@ function (ss::SummarySize)(obj::Array)
             dsize += length(obj)
         end
         size += dsize
-        if !isbitstype(eltype(obj)) && !isempty(obj)
+        if !isempty(obj) && !Base.allocatedinline(eltype(obj))
             push!(ss.frontier_x, obj)
             push!(ss.frontier_i, 1)
         end

diff --git a/test/misc.jl b/test/misc.jl
@@ -206,6 +206,11 @@ end
 @test summarysize(Vector{Nothing}(undef, 16)) == summarysize(Vector{Nothing}(undef, 32))
 @test summarysize(S32881()) == sizeof(Int)
 
+# issue #33675
+let vec = vcat(missing, ones(100000))
+    @test length(unique(summarysize(vec) for i = 1:20)) == 1
+end
+
 # issue #13021
 let ex = try
     Main.x13021 = 0