Skip to content

Commit

Permalink
printf.jl: add missing import of GMP (#22104)
Browse files Browse the repository at this point in the history
  • Loading branch information
rfourquet authored and ViralBShah committed May 28, 2017
1 parent efca045 commit 06521f1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion base/printf.jl
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file is a part of Julia. License is MIT: https://julialang.org/license

module Printf
using Base.Grisu
using Base: Grisu, GMP
export @printf, @sprintf

### printf formatter generation ###
Expand Down
3 changes: 2 additions & 1 deletion test/printf.jl
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@ for (fmt, val) in (("%i", "42"),
("%f", "42.000000"),
("%g", "42")),
num in (UInt16(42), UInt32(42), UInt64(42), UInt128(42),
Int16(42), Int32(42), Int64(42), Int128(42))
Int16(42), Int32(42), Int64(42), Int128(42), big"42")
#big"42" causes stack overflow on %a ; gh #14409
num isa BigInt && fmt in ["%a", "%#o", "%g"] && continue
@test @eval(@sprintf($fmt, $num) == $val)
end

Expand Down

2 comments on commit 06521f1

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

Please sign in to comment.