Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest uppercased package name when not found #2493

Closed
wants to merge 2 commits into from

Conversation

fonsp
Copy link
Member

@fonsp fonsp commented Apr 7, 2021

To help users in situations like fonsp/Pluto.jl#1068

@fredrikekre
Copy link
Member

This seems like an somewhat arbitrary thing to suggest (why not PLUTO for example)? There was a PR to Julia which suggested similar names when you try to load a package with a type (e.g. using pluto would suggest using Pluto) but I can't find it now. I think something like that would be much better.

@KristofferC
Copy link
Member

Suggesting similar package names based on what is available in the registry would probably work better.

@fonsp
Copy link
Member Author

fonsp commented Apr 14, 2021

This seems like an somewhat arbitrary thing to suggest

Good point! Feel free to close this PR, I'm not very invested in it

@fredrikekre
Copy link
Member

Suggesting similar package names based on what is available in the registry would probably work better.

Yea thats what I meant.

@StefanKarpinski
Copy link
Member

Edit distance with a low cost for case changes would be a good way to do this. Now that we have usage stats we can combine with a "language model" that uses package popularity to decide what's most likely.

@IanButterworth
Copy link
Member

Converted into a feature request. thanks @fonsp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants