Drop build info from julia version stored in manifest #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
approved these changes
Feb 18, 2022
|
See e.g. JuliaRegistries/General#39745 and JuliaRegistries/General#39836 for the motivation. |
IanButterworth
commented
Feb 18, 2022
src/Operations.jl
Outdated
| @@ -302,7 +305,7 @@ function resolve_versions!(env::EnvCache, registries::Vector{Registry.RegistryIn | |||
| @warn "julia version requirement for project not satisfied" _module=nothing _file=nothing | |||
| end | |||
| else | |||
| env.manifest.julia_version = VERSION | |||
| env.manifest.julia_version = dropbuild(VERSION) | |||
There was a problem hiding this comment.
@staticfloat I think the test failures mean that the branch above this is being used in regular pkg usage (where julia_version isn't supplied in the context) which IIUC shouldn't be happening.
Otherwise, I can't find anywhere else that manifest.julia_version is set.
There was a problem hiding this comment.
Can you print out the current stack trace in the above branch and run the tests again?
fredrikekre
pushed a commit
that referenced
this pull request
Mar 18, 2022
(cherry picked from commit 487fdd1, PR#2995)
fredrikekre
pushed a commit
that referenced
this pull request
Mar 18, 2022
(cherry picked from commit 487fdd1, PR#2995)
fredrikekre
pushed a commit
that referenced
this pull request
Mar 18, 2022
(cherry picked from commit 487fdd1, PR#2995)
KristofferC
pushed a commit
that referenced
this pull request
May 24, 2022
(cherry picked from commit 487fdd1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the full build info was proving too noisy for checked-in manifests on master