Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix importing executable before trying to compile its julia_main #813

Merged
merged 2 commits into from
May 24, 2023

Conversation

KristofferC
Copy link
Sponsor Member

Fixes #812

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #813 (22f7d1e) into master (33428b2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files           3        3           
  Lines         655      655           
=======================================
  Hits          541      541           
  Misses        114      114           
Impacted Files Coverage Δ
src/PackageCompiler.jl 92.80% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@IanButterworth
Copy link
Sponsor Member

Why wasn't this causing test failures?

@KristofferC
Copy link
Sponsor Member Author

It only happens when you have no compilation for the app.

@KristofferC KristofferC merged commit da05b2f into master May 24, 2023
@KristofferC KristofferC deleted the kc/include_pkg branch May 24, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.1.6 can not create_app
2 participants