Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CPU targets as cmdline args #804

Merged
merged 1 commit into from
May 12, 2023

Conversation

ven-k
Copy link
Member

@ven-k ven-k commented Apr 18, 2023

  • Fixes With 1.9.0-beta4, sysimages aren't built for the specified JULIA_CPU_TARGET #790
  • JULIA_CPU_TARGETS are ignored while building sysimage 1.9-rc2
  • Sysimages built with CPU targets as env var, tend to ignore them and result segfaults, when relocated to the target machine
    (See1) (On Julia#master and Julia#backports-release-1.9)
  • I've locally tested the PR against Julia binary2 associated with latest commit3 on Backport to 1.9 PR

Footnotes

  1. https://github.com/JuliaLang/julia/pull/48809#issuecomment-1505546852

  2. https://buildkite.com/organizations/julialang/pipelines/julia-release-1-dot-9/builds/175/jobs/01878fbd-b60d-4609-90a7-af65eb2e8bcb/artifacts/0187900b-8624-4214-9fae-c1b8247fc16d

  3. https://github.com/JuliaLang/julia/commit/00334655d2c46da4693d41a0d69fa9a089a71df4

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #804 (bb14715) into master (ef46e40) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
- Coverage   82.98%   82.59%   -0.39%     
==========================================
  Files           3        3              
  Lines         670      655      -15     
==========================================
- Hits          556      541      -15     
  Misses        114      114              
Impacted Files Coverage Δ
src/PackageCompiler.jl 92.78% <100.00%> (-0.21%) ⬇️

@ven-k
Copy link
Member Author

ven-k commented Apr 18, 2023

  • Once the next release of 1.9.0-* is out, 'will re-run the corr. tests.

  • The failure1 on 1.10-dev is unrelated

filter = false: Error During Test at D:\a\PackageCompiler.jl\PackageCompiler.jl\test\runtests.jl:80
  Got exception outside of a @test
  Unable to automatically download/install artifact 'fooifier' from sources listed in 'C:\Users\runneradmin\AppData\Local\Temp\jl_kTjrxv\MyApp\Artifacts.toml'.
  Sources attempted:
  - https://pkg.julialang.org/artifact/d61f806c76b57e54f343634c5219d00d4c81b077
      Error: RequestError: HTTP/1.1 404 Not Found while requesting https://pkg.julialang.org/artifact/d61f806c76b57e54f343634c5219d00d4c81b077
  - https://github.com/staticfloat/small_bin/raw/master/libfoo/libfoo.x86_64-w64-mingw32.tar.gz
      Error: Tree Hash Mismatch!
    Expected git-tree-sha1:   d61f806c76b57e54f343634c5219d00d4c81b077
    Calculated git-tree-sha1: 1[351](https://github.com/JuliaLang/PackageCompiler.jl/actions/runs/4730708525/jobs/8394765063?pr=804#step:5:354)b831192db9091d97e9b4bc84231ade05d210

Footnotes

  1. https://github.com/JuliaLang/PackageCompiler.jl/actions/runs/4730708525/jobs/8394765063?pr=804#step:5:197

@KristofferC
Copy link
Sponsor Member

JULIA_CPU_TARGETS are ignored while building sysimage 1.9-rc2

Is there an upstream issue regarding this?

@KristofferC
Copy link
Sponsor Member

The CI error seems relevant or?

ERROR: More than one command line CPU targets specified without a `--output-` flag specified
PackageCompiler.jl: Error During Test at /home/runner/work/PackageCompiler.jl/PackageCompiler.jl/test/runtests.jl:36

@ven-k
Copy link
Member Author

ven-k commented Apr 19, 2023

- Sysimages built with CPU targets as env var, tend to ignore them and result segfaults,  when relocated to the target machine
@KristofferC KristofferC merged commit 33428b2 into JuliaLang:master May 12, 2023
@ven-k ven-k deleted the vkb/--cpu-target branch January 16, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With 1.9.0-beta4, sysimages aren't built for the specified JULIA_CPU_TARGET
2 participants