Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow certain denpendencies to be excluded for sysimg #673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow certain denpendencies to be excluded for sysimg #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/PackageCompiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,9 @@ compiler (can also include extra arguments to the compiler, like `-g`).
transitive dependencies into the sysimage. This only makes a difference if some
packages do not load all their dependencies when themselves are loaded. Defaults to `true`.

- `excluded_dependencies`: A Vector of names of the (tansitive) dependencies to be excluded
from the system image.

### Advanced keyword arguments

- `base_sysimage::Union{Nothing, String}`: If a `String`, names an existing sysimage upon which to build
Expand All @@ -416,6 +419,7 @@ function create_sysimage(packages::Union{Nothing, Symbol, Vector{String}, Vector
script::Union{Nothing, String}=nothing,
sysimage_build_args::Cmd=``,
include_transitive_dependencies::Bool=true,
excluded_transitive_dependencies::Union{Nothing, Vector{String}}=nothing,
# Internal args
base_sysimage::Union{Nothing, String}=nothing,
julia_init_c_file=nothing,
Expand Down Expand Up @@ -490,7 +494,10 @@ function create_sysimage(packages::Union{Nothing, Symbol, Vector{String}, Vector
end
pkgid_deps = [Base.PkgId(uuid, name) for (name, uuid) in deps]
for pkgid_dep in pkgid_deps
if !(pkgid_dep in packages_sysimg) #
if !(pkgid_dep in packages_sysimg) #
if excluded_transitive_dependencies !== nothing && (pkgid_dep.name in excluded_transitive_dependencies)
continue
end
push!(packages_sysimg, pkgid_dep)
push!(new_frontier, pkgid_dep)
end
Expand Down Expand Up @@ -685,7 +692,9 @@ function create_app(package_dir::String,
cpu_target::String=default_app_cpu_target(),
include_lazy_artifacts::Bool=false,
sysimage_build_args::Cmd=``,
include_transitive_dependencies::Bool=true)
include_transitive_dependencies::Bool=true,
excluded_transitive_dependencies::Union{Nothing, Vector{String}}=nothing,
)
warn_official()

ctx = create_pkg_context(package_dir)
Expand Down Expand Up @@ -723,6 +732,7 @@ function create_app(package_dir::String,
cpu_target,
sysimage_build_args,
include_transitive_dependencies,
excluded_transitive_dependencies,
extra_precompiles = join(precompiles, "\n"))

for (app_name, julia_main) in executables
Expand Down