Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insufficient escaping #459

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Fix insufficient escaping #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9806d2e
Fix insufficient escaping.
GunnarFarneback Oct 19, 2020
6143260
Minor doc fix.
GunnarFarneback Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/devdocs/sysimages_part_1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ statements](https://github.com/JuliaLang/julia/issues/28808) running a
precompile statement can fail. The solution to these issues is to load all
modules in the sysimage by looping through `Base.loaded_modules` and to use a
`try-catch` for each precompile statement. In addition, we evaluate everything
in an anonymous module to not pollute the `Main` module which a bunch of
in an anonymous module to not pollute the `Main` module with a bunch of
symbols.

The end result is a `custom_sysimage.jl` file looking like:
Expand Down
2 changes: 1 addition & 1 deletion src/PackageCompiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ function create_sysimg_object_file(object_file::String, packages::Vector{String}
# println(statement)
# The compiler has problem caching signatures with `Vararg{?, N}`. Replacing
# N with a large number seems to work around it.
statement = replace(statement, r"Vararg{(.*?), N} where N" => s"Vararg{\1, 100}")
statement = replace(statement, r"Vararg{(.*?), N} where N" => s"Vararg{\\1, 100}")
try
Base.include_string(PrecompileStagingArea, statement)
catch
Expand Down