Skip to content

Commit

Permalink
fix lurking bug in _collect_artifacts (#919)
Browse files Browse the repository at this point in the history
`HostPlatform` was not fully qualified in the kwarg, though
this bug was never hit because the kwarg default is never used.
  • Loading branch information
sjkelly committed Jan 20, 2024
1 parent d5a8618 commit 8cd96a1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/PackageCompiler.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1449,7 +1449,7 @@ function pretty_byte_str(size)
end

# Copy pasted from Pkg since `collect_artifacts` doesn't allow lazy artifacts to get installed
function _collect_artifacts(pkg_root::String; platform::Base.BinaryPlatforms.AbstractPlatform=HostPlatform(), include_lazy::Bool)
function _collect_artifacts(pkg_root::String; platform::Base.BinaryPlatforms.AbstractPlatform=Base.BinaryPlatforms.HostPlatform(), include_lazy::Bool)
# Check to see if this package has an (Julia)Artifacts.toml
artifacts_tomls = Tuple{String,Base.TOML.TOMLDict}[]

Expand Down

0 comments on commit 8cd96a1

Please sign in to comment.