Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Log precompile _failures_ as well as errors. Pass log level through t…
…o helper process. This allows users to set the debug log level in the process, not just via the `JULIA_DEBUG=all` environment variable (we _thought_ we had enabled the debug messages, but we had not! 😬 ). Also, adds a log statement for precompile statements that _fail_, not just those that error. For example, this surfaces this failure: ```julia ┌ Debug: Precompilation failed: precompile(Tuple{typeof(Base.deepcopy_internal), Any, Base.IdDict{Any, Any}}) └ @ Main.anonymous none:31 ``` Which is a pattern I've noticed in our own precompilation failures, where Julia seems to be emitting a precompile statement with an abstract argument (`Any` in this case, but i've seen others) for a method that is _not_ marked `@nospecialize`, which causes `precompile()` to fail, since you cannot normally instantiate a method for abstract types. So that's a separate issue that we need to dig into, but this PR allows us to identify issues like these. :)
- Loading branch information