pk/rsa: Fix GC rooting issues and fill out API #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MbedTLS is passing raw pointers to C without rooting ownership all over the place. This fixes these issues in the pk/rsa code and fills out the API a bit for round-trip testing, as well as adding GC-safe wrappers over the internal mp integers for downstream code to use. Of course, the unsafe GC pattern is repeated elsewhere in this package, so this is just a first PR that fixed the API surface that I happened to need.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
==========================================
+ Coverage 76.22% 77.09% +0.87%
==========================================
Files 12 12
Lines 753 786 +33
==========================================
+ Hits 574 606 +32
- Misses 179 180 +1 ☔ View full report in Codecov by Sentry. |
|
@quinnj Bump 🙂 I would be very interested in the additions to the API (and the improvements, of course). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MbedTLS is passing raw pointers to C without rooting ownership all over the place. This fixes these issues in the pk/rsa code and fills out the API a bit for round-trip testing, as well as adding GC-safe wrappers over the internal mp integers for downstream code to use. Of course, the unsafe GC pattern is repeated elsewhere in this package, so this is just a first PR that fixed the API surface that I happened to need.