Take out extra, unnecessary isopen checks #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We check `Base.check_open`, then `iswritable` checks `isopen`, and then we check `isopen` again in `f_send` before we actually write. None of this is particularly problematic except that if our bio isn't open in `Base.check_open` then we get an `IOError`, but if `iswritable` fails, we get an `ArgumentError`. By delaying the `isopen` check until `f_send`, I believe that will result in a more predictable `MbedException` being thrown consistently.
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 74.06% 73.75% -0.32%
==========================================
Files 12 12
Lines 721 720 -1
==========================================
- Hits 534 531 -3
- Misses 187 189 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vtjnash
reviewed
Aug 27, 2022
|
|
||
| iswritable(ctx) || | ||
| throw(ArgumentError("`unsafe_write` requires `iswritable(::SSLContext)`")) | ||
| ctx.close_notify_sent && throw(ArgumentError("`unsafe_write` requires `!ctx.close_notify_sent`")) |
There was a problem hiding this comment.
This would normally generate ECONRESET IOError for other IO objects
There was a problem hiding this comment.
Yeah, as I've been digging in to all this, I feel like I'd rather be throwing IOErrors instead of MbedExceptions in several places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check
Base.check_open, theniswritablechecksisopen, and then wecheck
isopenagain inf_sendbefore we actually write. None of this isparticularly problematic except that if our bio isn't open in
Base.check_openthen we get an
IOError, but ifiswritablefails, we get anArgumentError.By delaying the
isopencheck untilf_send, I believe that will result ina more predictable
MbedExceptionbeing thrown consistently.I believe this was a source of the occasional
unsafe_writerequiresiswritable(::SSLContext)error where it was actually just a data race between the firstBase.check_openand the secondisopeniniswritable.