Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IJulia not found when installed, but not in user's Environment #834

Closed
wants to merge 1 commit into from

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Apr 15, 2019

Add the IJulia package that contains kernel.jl as last element of LOAD_PATH. If IJulia isn't found in the user's environment, this will then default to loading the version of IJulia that the kernel.jl was installed from.

This most commonly occurs when the user has installed IJulia in a custom environment, but not the top-level shared environment.
This is a fix for the issue discussed here: #820 (comment)

If IJulia isn't found in the user's environment, default to loading the
version of IJulia that the kernel.jl was installed from.
@NHDaly
Copy link
Member Author

NHDaly commented Feb 17, 2022

Bumping this PR, which I had let languish. @stevengj, would you be able to have a look.

Coming back to it again after a few years, I think this seems like a sane PR to me. I know that i've experienced this issue before when switching between julia environments, and i think this would be a nice simplification for users who install IJulia from a local environment and then attempt to open a Julia kernel directly via the Jupyter UI later.

@stevengj
Copy link
Member

Manually adding IJulia to the load path seems chancy to me. What if ZMQ is not in the environment either? Or an incompatible version of ZMQ?

@NHDaly
Copy link
Member Author

NHDaly commented Feb 18, 2022

🤔 yeah, makes sense! thanks for the thoughts. I'm happy to close it then. I think other approaches like automatically installing into the top-level Environment could be preferable. Thanks 👍 closing

@NHDaly NHDaly closed this Feb 18, 2022
@NHDaly NHDaly deleted the nhdaly/fix-IJulia-not-found branch February 18, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants