Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add at-cfunction #553

Merged
merged 1 commit into from
May 30, 2018
Merged

Add at-cfunction #553

merged 1 commit into from
May 30, 2018

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented May 23, 2018 •
edited
Loading

Fixes #535

@ararslan ararslan mentioned this pull request May 23, 2018
Closed
martinholters
martinholters reviewed May 28, 2018
View reviewed changes
test/runtests.jl
# 0.7.0-DEV.4762
let ptr = @cfunction(+, Int, (Int, Int))
@test ptr isa Ptr{Cvoid}
@test ptr != C_NULL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also @test ccall(ptr, Int, (Int, Int), 2, 3) == 5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@martinholters
Copy link
Member

AV failure due to #556. (Linux Travis seems to be using a Julia version old enough to not be hitting that.) OSX looks interesting:

 Resolving package versions...
ERROR: SystemError: unable to read directory /Users/travis/build/JuliaLang/Compat.jl/juliamnt/.Trashes: Permission denied

Pretty surely unrelated, but what's going on there?

@ararslan
Copy link
Member Author

Yeah that's pretty bizarre, absolutely no idea.

@martinholters
Copy link
Member

I've seen that elsewhere, too, but can't remember where just now. CC @KristofferC, @StefanKarpinski as it seems to be happing to package resolution or loading?

@KristofferC
Copy link
Sponsor Member

It is doing a walkdir in the packages path to find usages of standard libraries for old packages without project files. Perhaps we should use the onerror keyword to walkdir to make it more robust...

@martinholters
Copy link
Member

Is there something we can do here (except putting Project.toml back)?

@KristofferC
Copy link
Sponsor Member

Nightlies are updated now so perhaps no harm putting the Project file back? That was the plan IIRC.

@KristofferC KristofferC mentioned this pull request May 29, 2018
Closed
@KristofferC
Copy link
Sponsor Member

JuliaLang/Pkg.jl#316 should fix it though.

@martinholters
Copy link
Member

I'll close/re-open to re-trigger CI on top of the latest fixes and if that doesn't bring up anything except the known OSX failure, I'll go ahead and merge this later today.

@martinholters martinholters reopened this May 30, 2018
@martinholters martinholters merged commit aa24418 into master May 30, 2018
@martinholters martinholters deleted the aa/cfunction branch May 30, 2018 13:37
@ararslan
Copy link
Member Author

Thanks all!

@stevengj stevengj mentioned this pull request Jun 6, 2018
Closed
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for at-cfunction from #553 and #566
8e589b9
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for at-cfunction from #553 and #566
de90a80
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for at-cfunction from #553 and #566
a063fac
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for at-cfunction from #553 and #566
4f706a7
martinholters added a commit that referenced this pull request Oct 13, 2019
@martinholters
Drop support for Julia versions <1.0 (#665)
4fa5519 
* Bump required Julia version to 1.0

* Remove compatibility support code for:
  * `at-__MODULE__` (from #363)
  * `devnull`, `stdin`, `stdout`, and `stderr` from #499
  * `at-nospecialize` (from #385 and #409)
  * `isabstracttype` and `isconcretetype` (from #477)
  * `invokelatest` from #424
  * array-like access to `Cmd` from #379
  * `Val(n)` and `ntuple`/`reshape` with `Val` from #381 and #399
  * `logdet(::Any)` fallback from #382
  * `chol(::UniformScaling)` from #382
  * `pushfirst!`, `popfirst!` from #444
  * `fieldcount` from #386
  * `read(obj, ::Type{String})` from #385 and #580
  * `InexactError`, `DomainError`, and `OverflowError` constructors from #393
  * `corrected` kw arg to `cov` from #401
  * `adjoint` from #401
  * `partialsort` from #401
  * `pairs` from #428
  * `AbstractRange` from #400
  * `rtoldefault` from #401
  * `Dates.Period` rounding from #462
  * `IterativeEigensolvers` from #435
  * `occursin` from #520
  * `Char` concatenation from #406
  * `BitSet` from #407
  * `diagm` and `spdiagm` with pairs from #408
  * `Array` c'tors from `UniformScaling` from #412 and #438
  * `IOContext` ctor taking pairs from #427
  * `undef` from #417 and #514
  * `get` on `ENV` from #430
  * `ComplexF...` from #431
  * `tr` from #614
  * `textwidth` from #644
  * `isnumeric` from #543
  * `AbstractDict` from #435
  * `axes` #435 and #442
  * `Nothing` and `Cvoid` from #435
  * `Compat.SuiteSparse` from #435
  * `invpermute!` from #445
  * `replace` with a pair from #445
  * `copyto!` from #448
  * `contains` from #452
  * `CartesianIndices` and `LinearIndices` from #446, #455, and #524
  * `findall` from #466 (and #467).
  * `argmin` and `argmax` from #470, #472, and #622
  * `parentmodule` from #461
  * `codeunits` from #474
  * `nameof` from #471
  * `GC` from #477
  * `AbstractDisplay` from #482
  * `bytesavailable` from #483
  * `firstindex` and `lastindex` from #480 and #494
  * `printstyled` from #481
  * `hasmethod` from #486
  * `objectid` from #486
  * `Compat.find*` from #484 and #513
  * `repr` and `showable` from #497
  * `Compat.names` from #493 and #505
  * `Compat.round` and friends #500, #530, and #537
  * `IOBuffer` from #501 and #504
  * `range` with kw args and `LinRange` from #511
  * `cp` and `mv` from #512
  * `indexin` from #515
  * `isuppercase` and friends from #516
  * `dims` and `init` kwargs from #518, #528, #590, #592, and #613
  * `selectdim` from #522 and #531
  * `repeat` from #625
  * `fetch(::Task)` from #549
  * `isletter` from #542
  * `isbitstype` from #560
  * `at-cfunction` from #553 and #566
  * `codeunit` and `thisind` and friends from #573
  * `something` from #562
  * `permutedims` from #582
  * `atan` from #574
  * `split` and `rsplit` from #572
  * `mapslices` from #588
  * `floatmin` and `floatmax` from #607
  * `dropdims` from #618
  * required keyword arguments from #586
  * `CartesianRange` in `at-compat` from #377
  * `finalizer` from #416
  * `readline`, `eachline`, and `readuntil` from #477, #541, and #575
  * curried `isequal`, `==`, and `in` from #517
  * `Some` from #435 and #563
  * `at-warn` and friends from #458

* Remove old deprecations

* Deprecate:
  * `Compat.Sockets` from #545 and #594
  * `TypeUtils` from #304
  * `macros_have_sourceloc` from #355
  * `Compat.Sys` from #380, #433, and #552
  * `Compat.MathConstants` from #401
  * `Compat.Test`, `Compat.SharedArrays`, `Compat.Mmap`, and `Compat.DelimitedFiles` from #404
  * `Compat.Dates` from #413
  * `Compat.Libdl` from #465 (and #467)
  * `AbstractDateTime` from #443
  * `Compat.Printf` from #435
  * `Compat.LinearAlgebra` from #463
  * `Compat.SparseArrays` from #459
  * `Compat.Random` from #460, #601, and #647
  * `Compat.Markdown` from #492
  * `Compat.REPL` from #469
  * `Compat.Serialization` from #473
  * `Compat.Statistics` from #583
  * `Fix2` from #517
  * `Compat.Base64` from #418
  * `Compat.Unicode` from #432 and #507
  * `notnothing` from #435 and #563
  * `Compat.IteratorSize` and `Compat.IteratorEltype` from #451
  * `enable_debug(::Bool)` from #458
  * `Compat.Distributed` from #477
  * `Compat.Pkg` from #485
  * `Compat.InteractiveUtils` from #485
  * `Compat.LibGit2` from #487
  * `Compat.UUIDs` from #490
  * `Compat.qr` from #534
  * `Compat.rmul!` from #546
  * `Compat.norm` abd friends from #577

* Remove obsolete README entry, missed in #385

* Remove obsolete tests (e.g. missed in #372)

* Remove obsolete `VERSION` conditionals and some minor clean-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinholters martinholters martinholters left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ararslan @martinholters @KristofferC