added iszero #305
Merged
added iszero #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
force-pushed
the
iszero
branch
2 times, most recently
from
dd0c40d
to
863f7f5
Compare
tkelman
reviewed
Jan 14, 2017
| @@ -1708,6 +1708,14 @@ if !isdefined(Base, :numerator) | |||
| export numerator, denominator | |||
| end | |||
|
|
|||
| # julia #19950 | |||
| if !isdefined(Base, :iszero) | |||
| iszero(x) = x == iszero(x) | |||
There was a problem hiding this comment.
this is a stack overflow isn't it?
|
Failures on nightlies seem to be due to unrelated problems with |
ararslan
approved these changes
Jan 14, 2017
dpsanders
pushed a commit
to dpsanders/Compat.jl
that referenced
this pull request
Feb 1, 2017
stevengj
pushed a commit
that referenced
this pull request
Sep 5, 2018
* Remove `take!(::Task)` definition for Julia versions prior to 0.6 Was added in #307. * Remove `redirect_std*(f, stream)` definitions for Julia prior to v0.6 Were added in #275. * Remove at-__DIR__ macro definition for Julia versions prior to 0.6 Was added in #281. * Remove `broadcast` definition for equal-length tuples Was added in #324 and #328 * Remove definitions of `unsafe_get` and `isnull` fallsback Were added in #287. * Remove defintions of `xor` and `⊻` Were added in #289. * Definitions of `numerator` and `denominator` Were added in #290. * Remove defintion of `iszero` Was added in #305. * Remove definition of `>:` Was added in #336 * Remove definition of `take!(::Base.AbstractIOBuffer)` Was added in #290. * Remove definiton of `.&` and `.|` Were added in #306. * Remove definition of `Compat.isapprox` Was added in #309.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From JuliaLang/julia#19950