Skip to content

Commit

Permalink
Mark Compat.LibGit2 from #487 for deprecation
Browse files Browse the repository at this point in the history
  • Loading branch information
martinholters committed Oct 8, 2019
1 parent 426ef11 commit d5c49f4
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 17 deletions.
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ Currently, the `@compat` macro supports the following syntaxes:

## Module Aliases

* `using Compat.LibGit2` is provided on versions older than 0.7, where this library is
not yet part of the standard library ([#25706]).

* `using Compat.UUIDs` is provided on versions older than 0.7, where this library is
not yet part of the standard library ([#25819]).

Expand Down
7 changes: 1 addition & 6 deletions src/Compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ enable_debug(x::Bool) = x
import Distributed
import Pkg
import InteractiveUtils
import LibGit2


include("compatmacro.jl")
Expand All @@ -74,12 +75,6 @@ end
end
end

@static if VERSION < v"0.7.0-DEV.3724"
const LibGit2 = Base.LibGit2
else
import LibGit2
end

# 0.7.0-DEV.2695
@static if !isdefined(Base, :AbstractDisplay)
const AbstractDisplay = Display
Expand Down
8 changes: 8 additions & 0 deletions test/old.jl
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,14 @@ module TestInteractiveUtils
@test isdefined(@__MODULE__, :varinfo)
end

module TestLibGit2
using Compat
using Compat.LibGit2
using Compat.Test
@test isdefined(@__MODULE__, :LibGit2)
@test isdefined(@__MODULE__, :GitRepo)
end


# tests of removed functionality (i.e. justs tests Base)

Expand Down
8 changes: 0 additions & 8 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,6 @@ end

@test codeunit("foo") == codeunit(SubString("fooαβγ",1,3)) == UInt8

module TestLibGit2
using Compat
using Compat.LibGit2
using Compat.Test
@test isdefined(@__MODULE__, :LibGit2)
@test isdefined(@__MODULE__, :GitRepo)
end

@test eltype(Base.Multimedia.displays) <: AbstractDisplay

# 0.7.0-DEV.3481
Expand Down

0 comments on commit d5c49f4

Please sign in to comment.