Skip to content

Commit

Permalink
Drop compat code for adjoint from #401
Browse files Browse the repository at this point in the history
  • Loading branch information
martinholters committed Oct 1, 2019
1 parent 642878f commit 7644b73
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 20 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,6 @@ Currently, the `@compat` macro supports the following syntaxes:
* `select`* functions (`select`, `select!`, `selectperm`, `selectperm!`) are renamed to
`partialsort`* (`partialsort`, `partialsort!`, `partialsortperm`, `partialsortperm!`) ([#23051])

* `ctranspose` and `ctranspose!` are now `adjoint` and `adjoint!` ([#23235])

* Math constants (`π`, `pi`, `e`, `γ`, `eulergamma`, `catalan`, `φ`, `golden`) are moved to the
`MathConstants` module (available as `Compat.MathConstants`).
The name exported from `Base` for `e` is changed to ``. ([#23427])
Expand Down
7 changes: 0 additions & 7 deletions src/Compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@ end

include("compatmacro.jl")

# 0.7.0-DEV.1415
@static if !isdefined(Base, :adjoint)
const adjoint = ctranspose
const adjoint! = ctranspose!
export adjoint, adjoint!
end

# 0.7.0-DEV.1592
@static if !isdefined(Base, :MathConstants)
@eval module MathConstants
Expand Down
11 changes: 11 additions & 0 deletions test/old.jl
Original file line number Diff line number Diff line change
Expand Up @@ -222,3 +222,14 @@ end

# PR 22761
@test_throws OverflowError throw(OverflowError("overflow"))

# 0.7
let M = [1 + 2im 3 + 4im; 5 + 6im 7 + 8im],
M2 = adjoint(copy(M)),
Mc = [1 - 2im 5 - 6im; 3 - 4im 7 - 8im]

@test adjoint(M) == Mc
M2 .= 0
adjoint!(M2, M)
@test M2 == Mc
end
11 changes: 0 additions & 11 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -103,17 +103,6 @@ end
# 0.7
@test isa(1:2, AbstractRange)

# 0.7
let M = [1 + 2im 3 + 4im; 5 + 6im 7 + 8im],
M2 = adjoint(copy(M)),
Mc = [1 - 2im 5 - 6im; 3 - 4im 7 - 8im]

@test adjoint(M) == Mc
M2 .= 0
adjoint!(M2, M)
@test M2 == Mc
end

# 0.7
module TestMathConstants
using Compat.MathConstants
Expand Down

0 comments on commit 7644b73

Please sign in to comment.