Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only close old PRs if they have the same target branch as the current run #88

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Only close old PRs if they have the same target branch as the current run #88

merged 2 commits into from
Jan 9, 2023

Conversation

DilumAluthge
Copy link
Member

Fixes #87

Summary

  1. Put the target branch in the PR title.
  2. Put the target branch in the PR body.
  3. Put the target branch in the PR branch name.
  4. When deleting old PR branches, only delete old PR branches that have the same target branch as the current run.

Details

Before this PR, the PR branches have the following naming convention:

BumpStdlibs/StdlibName-commithash123

BumpStdlibs/StdlibName-commithash123-12345 # used in our integration tests to avoid having branches clash with each other

BumpStdlibs/StdlibName-commithash123-target-branch-name

BumpStdlibs-12345/StdlibName-commithash123-target-branch-name # used in our integration tests to avoid having branches clash with each other

bors bot added a commit that referenced this pull request Jan 9, 2023
@bors
Try #88:
0827725
@DilumAluthge DilumAluthge marked this pull request as ready for review January 9, 2023 02:12
IanButterworth
IanButterworth reviewed Jan 9, 2023
View reviewed changes
src/bump-stdlibs.jl Outdated Show resolved Hide resolved
@DilumAluthge
Copy link
Member Author

@IanButterworth Does this look good to you?

@JuliaLang JuliaLang deleted a comment from bors bot Jan 9, 2023
@IanButterworth
Copy link
Sponsor Member

Seems good. Easy to test once merged too

@DilumAluthge
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 9, 2023

Build succeeded:

@bors bors bot merged commit 472c7c8 into master Jan 9, 2023
@bors bors bot deleted the dpa/correct-closing branch January 9, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth Awaiting requested review from IanButterworth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't close PRs for different branches
2 participants
@DilumAluthge @IanButterworth