Fix version file parsing

[IanButterworth]

Fixes #61 ?

Untested

[DilumAluthge]

@IanButterworth I think I need to update the Julia forks that CI uses. I'll do so, and then we can retry CI.

[IanButterworth]

Ok. It fails on nightly though, so the regex still needs work

[DilumAluthge]

No, the CI Julia version refers only to the Julia binary we run. The Julia source repo we use for CI (https://github.com/bcbi-test/julia) is the same for all CI jobs.

[IanButterworth]

Oh I see. Ok

[DilumAluthge]

Instead of @assert (which may be disabled by default in the future), can you use conditionals?

[DilumAluthge]

I should probably document this better somewhere. Anyway, in production we have the upstream repository (https://github.com/JuliaLang/julia), but the bot user (DilumAluthgeBot) does not have commit permissions on the upstream, so it makes PRs from its fork (https://github.com/DilumAluthgeBot/julia).

In CI, we replicate this situation by having an "upstream" and a "fork" just for the purposes of CI.

The "CI upstream" (https://github.com/bcbi-test/julia) is not automatically kept in sync with the real upstream (https://github.com/JuliaLang/julia), but we should probably add a function at the beginning of the test suite that syncs the "CI upstream" with the "real upstream".

Row	CI or production	Upstream or fork	Owner	Repo
1	Production	Upstream	JuliaLang	JuliaLang/julia
2	Production	Fork	DilumAluthgeBot	DilumAluthgeBot/julia
3	CI	Upstream	bcbi-test	bcbi-test/julia
4	CI	Fork	bcbi-test-user	bcbi-test-user/julia

I have deleted and recreated the repos in rows 2, 3, and 4.

[DilumAluthge]

I was having some issues with CI on nightly. Can you comment out the "nightly" for now? We can uncomment in a separate PR.

[DilumAluthge]

Looks good - now let's make sure that all CI jobs pass.

[DilumAluthge]

@IanButterworth After you get the Git URL from the regex, can you strip() the leading and lagging whitespace?

It looks like the presence of leading and/or lagging whitespace is breaking the Git command.

[codecov]

Codecov Report

Merging #62 (afe42d6) into master (8c97932) will decrease coverage by 0.98%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   92.79%   91.80%   -0.99%     
==========================================
  Files           9        9              
  Lines         361      354       -7     
==========================================
- Hits          335      325      -10     
- Misses         26       29       +3     

Impacted Files	Coverage Δ
src/stdlib-list.jl	100.00% <100.00%> (ø)
src/bump-stdlibs.jl	93.75% <0.00%> (-1.88%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c97932...afe42d6. Read the comment docs.