Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the standard #2

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Follow the standard #2

merged 1 commit into from
Jul 18, 2019

Conversation

Gnimuc
Copy link
Member

@Gnimuc Gnimuc commented Jul 18, 2019

The old implementation actually violated the the standard.

@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #2 into master will decrease coverage by 6.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   73.33%   67.12%   -6.22%     
==========================================
  Files           1        1              
  Lines          60       73      +13     
==========================================
+ Hits           44       49       +5     
- Misses         16       24       +8
Impacted Files Coverage Δ
src/CEnum.jl 67.12% <100%> (-6.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e3c5e...c8f879a. Read the comment docs.

@Gnimuc Gnimuc merged commit 851bc67 into master Jul 18, 2019
@maleadt
Copy link
Member

maleadt commented Jul 18, 2019

Thanks!

@Gnimuc Gnimuc deleted the patch branch July 18, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants