refactor warp to be consistent with WarpedView #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## cs/warpedview #23 +/- ##
================================================
- Coverage 97.28% 97.2% -0.08%
================================================
Files 5 5
Lines 221 215 -6
================================================
- Hits 215 209 -6
Misses 6 6
Continue to review full report at Codecov.
|
timholy
approved these changes
Apr 21, 2017
| plain array and the `img[tform(x)]` is inbound. In the case | ||
| `tform(x)` maps to indices outside the original `img`, the value | ||
| / extrapolation scheme denoted by the optional parameter `fill` | ||
| (which defaults to `NaN`) is used to indicate locations for which |
There was a problem hiding this comment.
Maybe specify NaN, if the element type supports it, and 0 otherwise?
|
closing in favour of #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #13. This follows the idea from
WarpedViewthat theeltypeof the input should be preserved, since the transformation should only be about warping.